Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't hook activation function directly #13

Closed
JDGrimes opened this issue Sep 26, 2015 · 0 comments
Closed

Shouldn't hook activation function directly #13

JDGrimes opened this issue Sep 26, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@JDGrimes
Copy link
Owner

In our bootstrap we hook up the activation function directly. However, this is silly, because it should automatically be hooked up by register_activation_hook(). It is also unhelpful because it means that the tests won't catch an issue with the call to register_activation_hook() within the plugin (WordPoints/wordpoints#349).

I think the reason that I did it this way is because of issues with properly applying plugin_basename() to the plugin path. Let's see if we can resolve that somehow.

@JDGrimes JDGrimes added the bug label Sep 26, 2015
@JDGrimes JDGrimes self-assigned this Sep 26, 2015
@JDGrimes JDGrimes modified the milestones: 0.4.4, 0.5.0 Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant