Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v2 of the room delete API #49

Closed
JOJ0 opened this issue Dec 3, 2021 · 0 comments · Fixed by #113
Closed

Support v2 of the room delete API #49

JOJ0 opened this issue Dec 3, 2021 · 0 comments · Fixed by #113
Assignees
@JacksonChen666
Labels
core feature Feature request, has priority over regular features deprecation A change in Synapse needs to be taken care of good first issue Good for newcomers

Comments

@JOJ0
Copy link
Owner

JOJ0 commented Dec 3, 2021 •
edited
Loading

and make sure pre-1.48 Synapse is still using delete API v1: https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#delete-room-api

Also the new v2 API changed some behaviour:

block - Optional. If set to true, this room will be added to a blocking list, preventing future attempts to join the room. Rooms can be blocked even if they're not yet known to the homeserver (only with Version 1 of the API). Defaults to false.
@JOJ0 JOJ0 added core feature Feature request, has priority over regular features deprecation A change in Synapse needs to be taken care of good first issue Good for newcomers labels Feb 24, 2022
@JacksonChen666 JacksonChen666 mentioned this issue Feb 22, 2023
Closed
@JacksonChen666 JacksonChen666 self-assigned this Jul 26, 2023
@JacksonChen666 JacksonChen666 mentioned this issue Jul 26, 2023
Merged
@JacksonChen666 JacksonChen666 linked a pull request Jul 26, 2023 that will close this issue
Implement room delete v2 API #113
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacksonChen666 JacksonChen666

Labels
core feature Feature request, has priority over regular features deprecation A change in Synapse needs to be taken care of good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement room delete v2 API JacksonChen666/synadm
2 participants
@JOJ0 @JacksonChen666