Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore validation errors for external elements #2

Closed
goneall opened this issue Jan 9, 2025 · 4 comments
Closed

Ignore validation errors for external elements #2

goneall opened this issue Jan 9, 2025 · 4 comments

Comments

@goneall
Copy link

goneall commented Jan 9, 2025

Applying the SHACL validation against an SPDX serialization with external elements will fail.

One possible work-around is to ignore any errors where the Value node is an external element.

See spdx/spdx-3-model#956 for details on the issue.

@goneall
Copy link
Author

goneall commented Jan 9, 2025

Now that I read the README, it looks like this should be taken care of already in this library.

Below is a file with external elements that should be ignored. Let me know if there is an error in the SPDX file itself:

example3-bin.json

@goneall
Copy link
Author

goneall commented Jan 9, 2025

Should we also ignore validation errors for SPDX defined external elements (e.g. listed licenses)?

@goneall
Copy link
Author

goneall commented Jan 9, 2025

I'll clone this repo and see if I can find a solution.

@goneall
Copy link
Author

goneall commented Jan 9, 2025

Found the issue: incorrect subject name in imports - closing this issue

@goneall goneall closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant