-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JabRef's UI should adapt to the font size #11219
Comments
I’m an undergraduate computer science student, and I’m interested in working on this issue. Please let me know if I can take this on! |
Welcome to the vibrant world of open-source development with JabRef! Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly. In case you encounter failing tests during development, please check our developer FAQs! Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback. Happy coding! 🚀 |
We need to update the CSS definitions to use
em
instead ofpx
, becauseem
adapts with the font size.Update all pixel definitions (
px
) toem
. This is not an easy task, because theem
value depends on the font size, but the px size is a hard coded one.px
entry inBase.css
This takes a long time, because there are over 20 such values.
Please take screenshots before and after to ease reviewing.
Background material: https://openjfx.io/javadoc/22/javafx.graphics/javafx/scene/doc-files/cssref.html (linked from https://devdocs.jabref.org/code-howtos/javafx.html#resources, too)
Preparation
All .css definitions are spread around in the code base. We need to have them all in one
Base.css
to be able to work on some CSS issues.Migrate all CSS files to the Base.css. For instance: https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/gui/texparser/ParseLatexResult.css
Notes
Do not touch Dark.css. It needs to be kept for dark mode support. It does not contain any
px
values, because it does color only.The text was updated successfully, but these errors were encountered: