fixed the first underscore which was ignored

[laky241]

Fixes #12215

When multiple files were attached the tooltip and context menu in the "Linked File" tab removed the first underscore (_) from file names.

the file paths were correct internally and opened the right files.

javaFX treats _ as a shortcut key indicator

I updated ControlHelper.truncateString() to replace single underscores (_) with double underscores (__) before displaying text in the UI.

attached the SS of the fix

Mandatory checks

• I own the copyright of the code submitted and I licence it under the MIT license
• Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

Thanks, please add a changelog entry and add a test

[subhramit]

@laky241 do not remove the mandatory checks from the PR description.

[laky241]

@subhramit I’ll keep this in mind for future PRs. If there’s a way to add the mandatory checks now, please guide me, and I’ll update it.

[laky241]

@Siedlerchr @subhramit

when i was fixing this issue I noticed that when hovering over the Linked File tab in JabRef, the tooltip only displays the first attached file instead of listing all linked files.

I wanted to confirm if this is a known issue or intended behavior. If it's unintended, I’d be happy to work on a fix.

[Siedlerchr]

a) this will replace every occurend of an underscore. We only need to do ths if the first char is a underscore
b) This is not the correct position to do the replacement as the method should not do any magic as otherwise specificed (e.g. truncate)

=> Better create a new method for replaceFirstUnderscore and call this where needed

[calixtus]

Please note: If you do not guarantee that you own the copyright to your changes and you licence them under the terms of the MIT license agreement, we cannot accept your changes.