diff --git a/build.gradle b/build.gradle index f21eb83d8fb..567982ebb7c 100644 --- a/build.gradle +++ b/build.gradle @@ -138,7 +138,9 @@ dependencies { compile 'org.jsoup:jsoup:1.11.2' compile 'com.mashape.unirest:unirest-java:1.4.9' - compile 'commons-logging:commons-logging:1.2' + // >1.8.0-beta is required for java 9 compatibility + compile 'org.slf4j:slf4j-api:1.8.0-beta0' + compile 'org.apache.logging.log4j:log4j-slf4j-impl:2.10.0' compile 'org.apache.logging.log4j:log4j-jcl:2.10.0' compile 'org.apache.logging.log4j:log4j-api:2.10.0' compile 'org.apache.logging.log4j:log4j-core:2.10.0' @@ -167,7 +169,6 @@ dependencies { testCompile 'org.xmlunit:xmlunit-core:2.5.1' testCompile 'org.xmlunit:xmlunit-matchers:2.5.1' testCompile 'com.tngtech.archunit:archunit-junit:0.5.0' - testCompile 'org.slf4j:slf4j-jcl:1.7.25' // required by ArchUnit to enable logging over jcl testCompile "org.testfx:testfx-core:4.0.+" testCompile "org.testfx:testfx-junit:4.0.+" diff --git a/docs/adr/0002-use-slf4j-for-logging.md b/docs/adr/0002-use-slf4j-for-logging.md new file mode 100644 index 00000000000..b9aabc823d0 --- /dev/null +++ b/docs/adr/0002-use-slf4j-for-logging.md @@ -0,0 +1,43 @@ +# Use slf4j together with log4j2 for logging + +* Up to version 4.1 JabRef uses apache-ommons-logging 1.2 for logging errors and messages. However, this is not compatible with java 9 and is superseded by log4j. +* SLF4J provides a facade for several logging frameworks, including log4j and supports already java 9 +* Log4j is already defined as dependency and slf4j has already been required by a third party dependency + +## Considered Alternatives + +* [Log4j2](https://logging.apache.org/log4j/2.x/) +* [SLF4J with Log4j2 binding](https://logging.apache.org/log4j/2.x/maven-artifacts.html) +* [SLF4J with Logback binding](https://logback.qos.ch/) + +## Decision Outcome +* We chose slf4j with log4j2 binding, because it only requires minimal changes to our logging infrastructure and it is claimed that +> Apache Log4j 2 is an upgrade to Log4j that provides significant improvements over its predecessor, Log4j 1.x, and provides many of the improvements available in Logback while fixing some inherent problems in Logback’s architecture. +* Furthermore, as slf4j is a facade for several loggers, the underlying implementation can easily be changed in the future + + +## Pros and Cons of the Alternatives + +### Log4j2 + +* `+` Dependency already exists +* `+` Java 9 support since version 2.10 +* `-` Direct dependency + +### SLF4J with log4j2 binding + +* `+` Supports other loggers as well +* `+` Java 9 support +* `+` Already defined +* `+` Migration tool available +* `-` Logger statements require a slight different syntax + +### SLF4J with Logback binding + +* `+` Migration tool available +* `+` Native implementation of slf4j +* `-` Java 9 support only available in alpha +* `-` Different syntax than log4j/commons logging + + + diff --git a/src/main/java/org/jabref/FallbackExceptionHandler.java b/src/main/java/org/jabref/FallbackExceptionHandler.java index 1521b67cf60..ef65037ee54 100644 --- a/src/main/java/org/jabref/FallbackExceptionHandler.java +++ b/src/main/java/org/jabref/FallbackExceptionHandler.java @@ -1,14 +1,14 @@ package org.jabref; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Catch and log any unhandled exceptions. */ public class FallbackExceptionHandler implements Thread.UncaughtExceptionHandler { - private static final Log LOGGER = LogFactory.getLog(FallbackExceptionHandler.class); + private static final Logger LOGGER = LoggerFactory.getLogger(FallbackExceptionHandler.class); public static void installExceptionHandler() { Thread.setDefaultUncaughtExceptionHandler(new FallbackExceptionHandler()); diff --git a/src/main/java/org/jabref/JabRefException.java b/src/main/java/org/jabref/JabRefException.java index 42eacc77c72..0c312fc10df 100644 --- a/src/main/java/org/jabref/JabRefException.java +++ b/src/main/java/org/jabref/JabRefException.java @@ -1,11 +1,11 @@ package org.jabref; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class JabRefException extends Exception { - private static final Log LOGGER = LogFactory.getLog(JabRefException.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefException.class); private String localizedMessage; public JabRefException(String message) { diff --git a/src/main/java/org/jabref/JabRefExecutorService.java b/src/main/java/org/jabref/JabRefExecutorService.java index 3c587eaebe5..c3f3d9854e8 100644 --- a/src/main/java/org/jabref/JabRefExecutorService.java +++ b/src/main/java/org/jabref/JabRefExecutorService.java @@ -9,8 +9,8 @@ import java.util.concurrent.Executors; import java.util.concurrent.Future; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** @@ -19,7 +19,7 @@ public class JabRefExecutorService implements Executor { public static final JabRefExecutorService INSTANCE = new JabRefExecutorService(); - private static final Log LOGGER = LogFactory.getLog(JabRefExecutorService.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefExecutorService.class); private final ExecutorService executorService = Executors.newCachedThreadPool(r -> { Thread thread = new Thread(r); thread.setName("JabRef CachedThreadPool"); diff --git a/src/main/java/org/jabref/JabRefGUI.java b/src/main/java/org/jabref/JabRefGUI.java index 31e74f2941b..aa15ffdb0d6 100644 --- a/src/main/java/org/jabref/JabRefGUI.java +++ b/src/main/java/org/jabref/JabRefGUI.java @@ -34,12 +34,12 @@ import org.jabref.model.database.shared.DatabaseNotSupportedException; import org.jabref.preferences.JabRefPreferences; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class JabRefGUI { - private static final Log LOGGER = LogFactory.getLog(JabRefGUI.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefGUI.class); private static JabRefFrame mainFrame; private final List bibDatabases; @@ -47,7 +47,7 @@ public class JabRefGUI { private final List failed = new ArrayList<>(); private final List toOpenTab = new ArrayList<>(); - private String focusedFile; + private final String focusedFile; public JabRefGUI(List argsDatabases, boolean isBlank) { this.bibDatabases = argsDatabases; diff --git a/src/main/java/org/jabref/JabRefMain.java b/src/main/java/org/jabref/JabRefMain.java index c260f719128..d5fc08c4500 100644 --- a/src/main/java/org/jabref/JabRefMain.java +++ b/src/main/java/org/jabref/JabRefMain.java @@ -31,15 +31,15 @@ import org.jabref.model.entry.InternalBibtexFields; import org.jabref.preferences.JabRefPreferences; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * JabRef MainClass */ public class JabRefMain extends Application { - private static final Log LOGGER = LogFactory.getLog(JabRefMain.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefMain.class); private static String[] arguments; public static void main(String[] args) { diff --git a/src/main/java/org/jabref/cli/ArgumentProcessor.java b/src/main/java/org/jabref/cli/ArgumentProcessor.java index 2764dd1930f..eace9a6132c 100644 --- a/src/main/java/org/jabref/cli/ArgumentProcessor.java +++ b/src/main/java/org/jabref/cli/ArgumentProcessor.java @@ -51,12 +51,12 @@ import org.jabref.preferences.SearchPreferences; import com.google.common.base.Throwables; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class ArgumentProcessor { - private static final Log LOGGER = LogFactory.getLog(ArgumentProcessor.class); + private static final Logger LOGGER = LoggerFactory.getLogger(ArgumentProcessor.class); private final JabRefCLI cli; private final List parserResults; private final Mode startupMode; diff --git a/src/main/java/org/jabref/cli/JabRefCLI.java b/src/main/java/org/jabref/cli/JabRefCLI.java index 0333de6901a..f427c8e0dbb 100644 --- a/src/main/java/org/jabref/cli/JabRefCLI.java +++ b/src/main/java/org/jabref/cli/JabRefCLI.java @@ -12,12 +12,12 @@ import org.apache.commons.cli.Option; import org.apache.commons.cli.Options; import org.apache.commons.cli.ParseException; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class JabRefCLI { - private static final Log LOGGER = LogFactory.getLog(JabRefCLI.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefCLI.class); private final CommandLine cl; private List leftOver; diff --git a/src/main/java/org/jabref/gui/BasePanel.java b/src/main/java/org/jabref/gui/BasePanel.java index b18d28b1834..4fbd1b47e94 100644 --- a/src/main/java/org/jabref/gui/BasePanel.java +++ b/src/main/java/org/jabref/gui/BasePanel.java @@ -146,12 +146,12 @@ import com.google.common.eventbus.Subscribe; import com.jgoodies.forms.builder.FormBuilder; import com.jgoodies.forms.layout.FormLayout; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class BasePanel extends JPanel implements ClipboardOwner { - private static final Log LOGGER = LogFactory.getLog(BasePanel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(BasePanel.class); // Divider size for BaseFrame split pane. 0 means non-resizable. private static final int SPLIT_PANE_DIVIDER_SIZE = 4; diff --git a/src/main/java/org/jabref/gui/ClipBoardManager.java b/src/main/java/org/jabref/gui/ClipBoardManager.java index 12818869df6..a79eb860213 100644 --- a/src/main/java/org/jabref/gui/ClipBoardManager.java +++ b/src/main/java/org/jabref/gui/ClipBoardManager.java @@ -21,12 +21,12 @@ import org.jabref.model.entry.BibEntry; import org.jabref.model.entry.identifier.DOI; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class ClipBoardManager implements ClipboardOwner { - private static final Log LOGGER = LogFactory.getLog(ClipBoardManager.class); + private static final Logger LOGGER = LoggerFactory.getLogger(ClipBoardManager.class); private final Clipboard clipboard; diff --git a/src/main/java/org/jabref/gui/DefaultInjector.java b/src/main/java/org/jabref/gui/DefaultInjector.java index 7e430afd0d2..2ee788a9c02 100644 --- a/src/main/java/org/jabref/gui/DefaultInjector.java +++ b/src/main/java/org/jabref/gui/DefaultInjector.java @@ -11,12 +11,12 @@ import com.airhacks.afterburner.injection.Injector; import com.airhacks.afterburner.injection.PresenterFactory; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class DefaultInjector implements PresenterFactory { - private static final Log LOGGER = LogFactory.getLog(DefaultInjector.class); + private static final Logger LOGGER = LoggerFactory.getLogger(DefaultInjector.class); /** * This method takes care of creating dependencies. diff --git a/src/main/java/org/jabref/gui/EntryTypeDialog.java b/src/main/java/org/jabref/gui/EntryTypeDialog.java index 83d655539f9..4a8961c937d 100644 --- a/src/main/java/org/jabref/gui/EntryTypeDialog.java +++ b/src/main/java/org/jabref/gui/EntryTypeDialog.java @@ -45,8 +45,8 @@ import org.jabref.model.entry.IEEETranEntryTypes; import com.jgoodies.forms.builder.ButtonBarBuilder; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Dialog that prompts the user to choose a type for an entry. @@ -54,7 +54,7 @@ */ public class EntryTypeDialog extends JabRefDialog implements ActionListener { - private static final Log LOGGER = LogFactory.getLog(EntryTypeDialog.class); + private static final Logger LOGGER = LoggerFactory.getLogger(EntryTypeDialog.class); private static final int COLUMN = 3; private final JabRefFrame frame; private final CancelAction cancelAction = new CancelAction(); diff --git a/src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java b/src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java index fbf049a942d..0d4b38b0971 100644 --- a/src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java +++ b/src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java @@ -82,8 +82,8 @@ import org.jabref.preferences.JabRefPreferences; import com.jgoodies.forms.builder.ButtonBarBuilder; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * GUI Dialog for the feature "Find unlinked files". @@ -99,7 +99,7 @@ public class FindUnlinkedFilesDialog extends JabRefDialog { public static final String ACTION_SHORT_DESCRIPTION = Localization .lang("Searches for unlinked PDF files on the file system"); - private static final Log LOGGER = LogFactory.getLog(FindUnlinkedFilesDialog.class); + private static final Logger LOGGER = LoggerFactory.getLogger(FindUnlinkedFilesDialog.class); private static final String GLOBAL_PREFS_WORKING_DIRECTORY_KEY = "findUnlinkedFilesWD"; private static final String GLOBAL_PREFS_DIALOG_SIZE_KEY = "findUnlinkedFilesDialogSize"; diff --git a/src/main/java/org/jabref/gui/GUIGlobals.java b/src/main/java/org/jabref/gui/GUIGlobals.java index 61e3d4364ec..2b3ba25b364 100644 --- a/src/main/java/org/jabref/gui/GUIGlobals.java +++ b/src/main/java/org/jabref/gui/GUIGlobals.java @@ -19,8 +19,8 @@ import org.jabref.model.entry.specialfields.SpecialField; import org.jabref.preferences.JabRefPreferences; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Static variables for graphics files and keyboard shortcuts. @@ -45,7 +45,7 @@ public class GUIGlobals { public static final Color ENTRY_EDITOR_LABEL_COLOR = new Color(100, 100, 150); // Empty field, blue. static final Color INACTIVE_TABBED_COLOR = Color.black; // inactive Database - private static final Log LOGGER = LogFactory.getLog(GUIGlobals.class); + private static final Logger LOGGER = LoggerFactory.getLogger(GUIGlobals.class); private static final Map TABLE_ICONS = new HashMap<>(); // Contains table icon mappings. Set up static final Color ACTIVE_TABBED_COLOR = ENTRY_EDITOR_LABEL_COLOR.darker(); // active Database (JTabbedPane) diff --git a/src/main/java/org/jabref/gui/IconTheme.java b/src/main/java/org/jabref/gui/IconTheme.java index 0f87021fe75..0b78c7cd09e 100644 --- a/src/main/java/org/jabref/gui/IconTheme.java +++ b/src/main/java/org/jabref/gui/IconTheme.java @@ -33,8 +33,8 @@ import de.jensd.fx.glyphs.materialdesignicons.MaterialDesignIcon; import de.jensd.fx.glyphs.materialdesignicons.MaterialDesignIconView; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class IconTheme { @@ -45,7 +45,7 @@ public class IconTheme { public static final Color DEFAULT_DISABLED_COLOR = JabRefPreferences.getInstance().getColor(JabRefPreferences.ICON_DISABLED_COLOR); public static Font FONT; private static final String DEFAULT_ICON_PATH = "/images/external/red.png"; - private static final Log LOGGER = LogFactory.getLog(IconTheme.class); + private static final Logger LOGGER = LoggerFactory.getLogger(IconTheme.class); private static final Map KEY_TO_ICON = readIconThemeFile( IconTheme.class.getResource("/images/Icons.properties"), "/images/external/"); diff --git a/src/main/java/org/jabref/gui/JEditorPaneWithHighlighting.java b/src/main/java/org/jabref/gui/JEditorPaneWithHighlighting.java index 147df8f34f0..71235c5d08e 100644 --- a/src/main/java/org/jabref/gui/JEditorPaneWithHighlighting.java +++ b/src/main/java/org/jabref/gui/JEditorPaneWithHighlighting.java @@ -14,12 +14,12 @@ import org.jabref.gui.fieldeditors.JTextAreaWithHighlighting; import org.jabref.logic.search.SearchQueryHighlightListener; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class JEditorPaneWithHighlighting extends JEditorPane implements SearchQueryHighlightListener { - private static final Log LOGGER = LogFactory.getLog(JTextAreaWithHighlighting.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JTextAreaWithHighlighting.class); public void highlightPattern(Optional highlightPattern) { Highlighter highlighter = getHighlighter(); diff --git a/src/main/java/org/jabref/gui/JabRefFrame.java b/src/main/java/org/jabref/gui/JabRefFrame.java index 35a57419c90..47db19b25e3 100644 --- a/src/main/java/org/jabref/gui/JabRefFrame.java +++ b/src/main/java/org/jabref/gui/JabRefFrame.java @@ -143,15 +143,15 @@ import org.jabref.preferences.SearchPreferences; import com.google.common.eventbus.Subscribe; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import osx.macadapter.MacAdapter; /** * The main window of the application. */ public class JabRefFrame extends JFrame implements OutputPrinter { - private static final Log LOGGER = LogFactory.getLog(JabRefFrame.class); + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefFrame.class); // Frame titles. private static final String FRAME_TITLE = "JabRef"; @@ -653,7 +653,7 @@ public void windowClosing(WindowEvent e) { try { new MacAdapter().registerMacEvents(this); } catch (Exception e) { - LOGGER.fatal("Could not interface with Mac OS X methods.", e); + LOGGER.error("Could not interface with Mac OS X methods.", e); } } diff --git a/src/main/java/org/jabref/gui/PreviewPanel.java b/src/main/java/org/jabref/gui/PreviewPanel.java index fe0b096ba32..33f73d3e58d 100644 --- a/src/main/java/org/jabref/gui/PreviewPanel.java +++ b/src/main/java/org/jabref/gui/PreviewPanel.java @@ -34,15 +34,15 @@ import org.jabref.preferences.PreviewPreferences; import com.google.common.eventbus.Subscribe; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Displays an BibEntry using the given layout format. */ public class PreviewPanel extends ScrollPane implements SearchQueryHighlightListener, EntryContainer { - private static final Log LOGGER = LogFactory.getLog(PreviewPanel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(PreviewPanel.class); private final ClipBoardManager clipBoardManager; private final DialogService dialogService; diff --git a/src/main/java/org/jabref/gui/SidePaneManager.java b/src/main/java/org/jabref/gui/SidePaneManager.java index 500c78af892..d9af9434c18 100644 --- a/src/main/java/org/jabref/gui/SidePaneManager.java +++ b/src/main/java/org/jabref/gui/SidePaneManager.java @@ -15,15 +15,15 @@ import org.jabref.gui.maintable.MainTable; import org.jabref.preferences.JabRefPreferences; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Manages visibility of SideShowComponents in a given newly constructed * sidePane. */ public class SidePaneManager { - private static final Log LOGGER = LogFactory.getLog(SidePaneManager.class); + private static final Logger LOGGER = LoggerFactory.getLogger(SidePaneManager.class); private final JabRefFrame frame; diff --git a/src/main/java/org/jabref/gui/actions/IntegrityCheckAction.java b/src/main/java/org/jabref/gui/actions/IntegrityCheckAction.java index 590c2795028..25a186f33e7 100644 --- a/src/main/java/org/jabref/gui/actions/IntegrityCheckAction.java +++ b/src/main/java/org/jabref/gui/actions/IntegrityCheckAction.java @@ -33,12 +33,12 @@ import com.jgoodies.forms.builder.FormBuilder; import com.jgoodies.forms.layout.FormLayout; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class IntegrityCheckAction extends MnemonicAwareAction { - private static final Log LOGGER = LogFactory.getLog(IntegrityCheckAction.class); + private static final Logger LOGGER = LoggerFactory.getLogger(IntegrityCheckAction.class); private static final String ELLIPSES = "..."; private final JabRefFrame frame; diff --git a/src/main/java/org/jabref/gui/actions/LookupIdentifierAction.java b/src/main/java/org/jabref/gui/actions/LookupIdentifierAction.java index 9e1fb4f1126..2f488fdb45b 100644 --- a/src/main/java/org/jabref/gui/actions/LookupIdentifierAction.java +++ b/src/main/java/org/jabref/gui/actions/LookupIdentifierAction.java @@ -9,12 +9,12 @@ import org.jabref.gui.worker.LookupIdentifiersWorker; import org.jabref.logic.importer.IdFetcher; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class LookupIdentifierAction extends MnemonicAwareAction { - private static final Log LOGGER = LogFactory.getLog(LookupIdentifierAction.class); + private static final Logger LOGGER = LoggerFactory.getLogger(LookupIdentifierAction.class); private final JabRefFrame frame; private final IdFetcher fetcher; @@ -32,7 +32,7 @@ public void actionPerformed(ActionEvent actionEvent) { try { BasePanel.runWorker(new LookupIdentifiersWorker(frame, fetcher)); } catch (Exception e) { - LOGGER.error(e); + LOGGER.error("Problem running ID Worker", e); } } } diff --git a/src/main/java/org/jabref/gui/actions/NewEntryAction.java b/src/main/java/org/jabref/gui/actions/NewEntryAction.java index b404dfea3af..c8f4a198591 100644 --- a/src/main/java/org/jabref/gui/actions/NewEntryAction.java +++ b/src/main/java/org/jabref/gui/actions/NewEntryAction.java @@ -16,11 +16,11 @@ import org.jabref.model.entry.EntryType; import org.jabref.model.strings.StringUtil; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class NewEntryAction extends MnemonicAwareAction { - private static final Log LOGGER = LogFactory.getLog(NewEntryAction.class); + private static final Logger LOGGER = LoggerFactory.getLogger(NewEntryAction.class); private final JabRefFrame jabRefFrame; private String type; // The type of item to create. diff --git a/src/main/java/org/jabref/gui/autosaveandbackup/AutosaveUIManager.java b/src/main/java/org/jabref/gui/autosaveandbackup/AutosaveUIManager.java index 52efccbb5f0..99b97cf6f9d 100644 --- a/src/main/java/org/jabref/gui/autosaveandbackup/AutosaveUIManager.java +++ b/src/main/java/org/jabref/gui/autosaveandbackup/AutosaveUIManager.java @@ -5,8 +5,8 @@ import org.jabref.model.database.event.AutosaveEvent; import com.google.common.eventbus.Subscribe; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * This class has an abstract UI role as it listens for an {@link AutosaveEvent} @@ -14,7 +14,7 @@ */ public class AutosaveUIManager { - private static final Log LOGGER = LogFactory.getLog(AutosaveUIManager.class); + private static final Logger LOGGER = LoggerFactory.getLogger(AutosaveUIManager.class); private final BasePanel panel; diff --git a/src/main/java/org/jabref/gui/collab/ChangeScanner.java b/src/main/java/org/jabref/gui/collab/ChangeScanner.java index a35ca71bad0..f8356608d34 100644 --- a/src/main/java/org/jabref/gui/collab/ChangeScanner.java +++ b/src/main/java/org/jabref/gui/collab/ChangeScanner.java @@ -34,11 +34,11 @@ import org.jabref.model.entry.BibtexString; import org.jabref.model.metadata.MetaData; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class ChangeScanner implements Runnable { - private static final Log LOGGER = LogFactory.getLog(ChangeScanner.class); + private static final Logger LOGGER = LoggerFactory.getLogger(ChangeScanner.class); private final File file; private final Path tempFile; diff --git a/src/main/java/org/jabref/gui/collab/DatabaseChangeMonitor.java b/src/main/java/org/jabref/gui/collab/DatabaseChangeMonitor.java index 926bc13fce5..7d73267a9df 100644 --- a/src/main/java/org/jabref/gui/collab/DatabaseChangeMonitor.java +++ b/src/main/java/org/jabref/gui/collab/DatabaseChangeMonitor.java @@ -16,11 +16,11 @@ import org.jabref.logic.util.io.FileUtil; import org.jabref.model.database.BibDatabaseContext; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class DatabaseChangeMonitor implements FileUpdateListener { - private static final Log LOGGER = LogFactory.getLog(DatabaseChangeMonitor.class); + private static final Logger LOGGER = LoggerFactory.getLogger(DatabaseChangeMonitor.class); private final BibDatabaseContext database; private final FileUpdateMonitor fileMonitor; diff --git a/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java b/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java index fa11e45d318..7a63b4aed8f 100644 --- a/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java +++ b/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java @@ -18,12 +18,12 @@ import org.jabref.model.database.BibDatabase; import org.jabref.model.entry.BibEntry; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class EntryChangeViewModel extends ChangeViewModel { - private static final Log LOGGER = LogFactory.getLog(EntryChangeViewModel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(EntryChangeViewModel.class); public EntryChangeViewModel(BibEntry memEntry, BibEntry tmpEntry, BibEntry diskEntry) { super(); diff --git a/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java b/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java index 425f0bae798..0f7d0a11779 100644 --- a/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java +++ b/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java @@ -15,12 +15,12 @@ import org.jabref.model.database.BibDatabase; import org.jabref.model.entry.BibEntry; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class EntryDeleteChangeViewModel extends ChangeViewModel { - private static final Log LOGGER = LogFactory.getLog(EntryDeleteChangeViewModel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(EntryDeleteChangeViewModel.class); private final BibEntry memEntry; private final BibEntry tmpEntry; diff --git a/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java index ba7ff79648a..20bf1099ef6 100644 --- a/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java +++ b/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java @@ -11,12 +11,12 @@ import org.jabref.model.database.KeyCollisionException; import org.jabref.model.entry.BibtexString; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class StringAddChangeViewModel extends ChangeViewModel { - private static final Log LOGGER = LogFactory.getLog(StringAddChangeViewModel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(StringAddChangeViewModel.class); private final BibtexString string; private final InfoPane tp = new InfoPane(); diff --git a/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java index 003dd5fde5c..19e68f3a0b9 100644 --- a/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java +++ b/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java @@ -12,12 +12,12 @@ import org.jabref.model.database.KeyCollisionException; import org.jabref.model.entry.BibtexString; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class StringChangeViewModel extends ChangeViewModel { - private static final Log LOGGER = LogFactory.getLog(StringChangeViewModel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(StringChangeViewModel.class); private final BibtexString string; private final String disk; diff --git a/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java index 98170b28fed..e9bda7c9f40 100644 --- a/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java +++ b/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java @@ -12,12 +12,12 @@ import org.jabref.model.database.KeyCollisionException; import org.jabref.model.entry.BibtexString; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class StringNameChangeViewModel extends ChangeViewModel { - private static final Log LOGGER = LogFactory.getLog(StringNameChangeViewModel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(StringNameChangeViewModel.class); private final BibtexString string; private final String mem; private final String disk; diff --git a/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java index c47f6134594..4501888a240 100644 --- a/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java +++ b/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java @@ -10,11 +10,11 @@ import org.jabref.model.database.BibDatabase; import org.jabref.model.entry.BibtexString; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class StringRemoveChangeViewModel extends ChangeViewModel { - private static final Log LOGGER = LogFactory.getLog(StringRemoveChangeViewModel.class); + private static final Logger LOGGER = LoggerFactory.getLogger(StringRemoveChangeViewModel.class); private final BibtexString string; private final BibtexString inMem; diff --git a/src/main/java/org/jabref/gui/contentselector/ContentSelectorDialog.java b/src/main/java/org/jabref/gui/contentselector/ContentSelectorDialog.java index 2fb061ee6e9..8801779f71e 100644 --- a/src/main/java/org/jabref/gui/contentselector/ContentSelectorDialog.java +++ b/src/main/java/org/jabref/gui/contentselector/ContentSelectorDialog.java @@ -41,14 +41,14 @@ import org.jabref.model.metadata.MetaData; import com.jgoodies.forms.builder.ButtonBarBuilder; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class ContentSelectorDialog extends JabRefDialog { private static final String WORD_FIRSTLINE_TEXT = Localization.lang("