Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ported files #19

Open
Jacherr opened this issue Jul 29, 2024 · 0 comments
Open

Refactor ported files #19

Jacherr opened this issue Jul 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Jacherr
Copy link
Owner

Jacherr commented Jul 29, 2024

Some files in the assyst2 codebase are direct ports of their legacy counterparts. One notable example is assyst-core/src/bad_translator.rs. However, this implementation probably does not take advantage of newer features in the rewrite and as such can probably be refactored heavily to more closely match the new conventions that the rewrite provides. This also applies to any other ported files and functions (such as a lot of command execution functions).

@Jacherr Jacherr added the enhancement New feature or request label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant