Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places assets inline, rather than relying on fs? #58

Open
jonathon-love opened this issue Nov 9, 2022 · 0 comments
Open

Places assets inline, rather than relying on fs? #58

jonathon-love opened this issue Nov 9, 2022 · 0 comments

Comments

@jonathon-love
Copy link

hi,

we've used dialogs for some time, but we're in the process of updating our toolchain to use vite rather than browserify. it seems that browserify (or is it babel?) made it really easy to sub dialogs' calls to fs.readFileSync() ... however i don't think this is so straightforward with modern tools like vite.

what do you think about replacing the fs.readFileSync() calls in dialogs with inlined resources?

it is a bit funny that dialogs makes use of both fs.readFileSync() and document.appendChild() meaning in it's unprocessed form, it can't run in the browser, or in node.

with thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant