Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing UI for Game-Adjustments and Multi-Monitor Support? #13

Open
ThreeHeadMonkey opened this issue Sep 28, 2024 · 0 comments
Open

Comments

@ThreeHeadMonkey
Copy link

Hey there @Jan-9C

First of all, thanks for this great work. If it matters, I am able to speak german and english, so either answer would be fine for me.
However, when using ur product, it is working fine for Elden Ring and I managed to change it in regard to being usable for a 1440p resolution on the main screen.

But I recognized a couple of things, that might be worth to be checked from your side:

  1. The usability for people without python knowledge is VERY limited. A more detailed readme/guide for some edge cases like using multiple monitors or the adjustment for an game would be very nice, since you have the knowledge of how to use it properly - others might not. So here are my issues:

1.1 The readme works fine for the cropimage. Left click for the left upper corner, right click for the right lower corner. Done.
However, if my deathmessage part would have been in the lower segment of the screenshot, I would have had no chance to select it, since I use a multi-monitor-setup with various resolutions that result in an oversized picture I would need to work with.
Currently there opens a window with the picture for coordinate-selection, but its showing it in its native size. It would be way more handy, if you could display the picture of whatever size in a one-screen-solution with some navigation elements.
Like in GIMP or something like that.

As an example here is the screenshot I am using, it works for Elden Ring for example.
(https://github.com/user-attachments/assets/b5ab07e0-bc3d-44ca-aacc-b88df239406f)

1.2 if it comes to the maskgenerator.py, it is not clear for me, what the mask later is used for and how it works. According to the python code, I would assume its about picking a color, but this is just a wild guess right now.

When I open my screenshot it is marked in red in this case. But if its not the color of the text I am searching for, what do I need to click then? Because If I click on the text, I only get a black screen as a result. Clicking wildly around the image never resulted in something recognizeable. And since I don't know what the result should look like, its hard to find out what I am doing wrong.

Here are my final thoughts:

It would be awesome, if you could assist me with this one, since I really would like to use this tool for more than one game in the future. If you dont want to put more effort into this, I am fine - but if you decide to develop it further, I have a couple of ideas, also being willing to put out "tutorials", if this is not what you want to do. However, I still need to understand the tool in a way, that enables me to adjust it for other games first.

If it comes to UI, I have a couple of thoughts, you might want to look into:
A: What about creating an UI for the Crop/Merge etc. tools?

B: Solution, which can handle also a multi-monitor screenshot within one window. (Minium, I would recommend this)

C: If wou want to have comfort functions, I would recommend zooming in/out and a drag/drop navigation via mouse or scrollbars on the sides. To select something, you could use a button to activate the crop-mode (like a certain tool in GIMP) then you click the area. It would be also awesome, if you could see, what you selected. Now a User-Input to put in the name of the file. Done.

D: Ideally after C is done, it would automatically lead to the mask. At least it could ask for it. If not needed you click on no. If you click yes, it uses the same picture as before as input file and opens the file in a fixed environment (see B/C), so also bigger screenshots can be handled. Also here, you should be able to navigate around the picture and then activate the tool to do your selection. If you decide that your mask is ok, its saving it and gets back to the original menu. You can now either create more maks and then merge it or you close the tool. Done.

E: I would also implement a parameter within the configs, which defines the game/resolution its defined for.
This information then could be also displayed on the GUI to make it more transparant, whats currently loaded.

F: To round up everything, I would recommend to make the crop-image-tool being startable from the deathcounter-GUI already.
The minimum solution would be to keep the tools seperated from each other, but connect them to each other, so they can be opened without using a CMD. The ideal solution would be a mixed up GUI, which merges all three tools into one. :)

The tool and what it is able to, is amazing already. And the potential to be used for multiple games, could be a big thing within the streaming community, if it not is already. But it all starts with making it a more usable and self-explaining.

Sorry for the long text, if you dont care about all this, it's also fine. Then it would be amazing, if you could help me to get your current solution working for me and my setup for at least 2-3 other games, so i can reproduze this in the future alone without anyones help. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant