Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barWidth Method and barPadding property should be in JBBarChartView header file. #104

Closed
kidsid49 opened this issue Sep 2, 2014 · 2 comments

Comments

@kidsid49
Copy link

kidsid49 commented Sep 2, 2014

For showing labels on x-axis properly one should have to knowledge of the barWidth and barPadding.
I think they should be in API instead of in implementation file.

@terryworona
Copy link
Collaborator

I'd like to keep these private for now.

If you really need access to them, simply create a private interface for JBBarChartView:

@interface JBBarChartView (Private)

- (CGFloat)barPadding;
- (CGFloat)barWidth;

@end 

You should wrap your calls in @performsSelector to stay safe.

@radianttap
Copy link

Terry, what do you mean by "create private interface"? If I add my own category to JBBarChartView, barWidth and barPadding as not visible to it, since they are private method/property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants