Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie handling is all over the place #1

Open
Jaymon opened this issue Dec 4, 2017 · 0 comments
Open

Cookie handling is all over the place #1

Jaymon opened this issue Dec 4, 2017 · 0 comments

Comments

@Jaymon
Copy link
Owner

Jaymon commented Dec 4, 2017

Requests uses CookieJar but Selenium uses its own dict format. But since I added Selenium first I standardized on their format for brow.core.Cookies but I think it would be better to switch this and standardize on CookieJar because then I can use Python's built-in stuff like FileCookieJar to cache the cookies instead of the custom pickle solution I have now.

Maybe helpful links about cookies:
https://stackoverflow.com/questions/1969232/allowed-characters-in-cookies
https://docs.python.org/2/library/cookie.html (the other python Cookie lib)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant