-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default host IP value incompatible with Heroku #154
Comments
Unix socket is also possible, if Node is behind nginx or lighttpd. Don't you think that mongdb-style "Connection String URI" is better format then
And default will be |
Actually thanks to the great support-team from https://modulus.io/ |
Good points @azproduction, thanks. I've made some major changes to the way keystone is initialised, supporting using the options
ref http://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback for docs on I haven't been able to successfully test the "Connection String URI" option (which should work if you set the The Port and Host options work properly, and it now lets you know if it's using the default port 3000 or a specifically assigned one in the console log. |
As noted by @bladey on issue #148, assigning a default IP of '127.0.0.1' (localhost) doesn't work on PAAS services like Heroku out of the box.
Explicitly assigning an IP Address of '0.0.0.0' to express does seem to work correctly (thanks @TheBenji), so it makes sense to instead use that as the Keystone default.
Since I'd prefer to have Keystone work on Heroku without any more config than absolutely required, I'm going to implement that.
If anyone knows of any issues it may create, please let me know!
The text was updated successfully, but these errors were encountered: