Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies for react > 16 #148

Open
mikeboyle opened this issue Dec 3, 2018 · 1 comment
Open

Update peerDependencies for react > 16 #148

mikeboyle opened this issue Dec 3, 2018 · 1 comment

Comments

@mikeboyle
Copy link

mikeboyle commented Dec 3, 2018

Our team loves this library and we are using v1.0.0 without any issues in a project with react and react-dom ~16.6.0.

However, when installing the package, we are getting warnings because the peerDependencies in package.json is still set to versions of react and react-dom below 16:

"react": ">=15.5 <16",
"react-dom": ">=15.5 <16"

It looks like the < 16 restriction was set some time ago in https://github.com/JedWatson/react-codemirror/pull/64/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R30 . Is it possible that the library works just fine with react and react-dom > 16, or are there known issues with that version that I have not happened to encounter yet?

If there are no known issues, any objections to opening a PR to adjust the peer dependencies?

@scniro
Copy link

scniro commented Dec 26, 2018

@mikeboyle This lib is pretty much abandoned. Check out react-codemirror2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants