-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isomorphic render issue on 1.0rc2 #1325
Comments
Seems it increments a global InstanceID on mount:
It appears I can solve this by setting the instanceID as a prop, but it would be nice if this were solved using default settings. |
Looks like there is still an issue:
|
It appears like Object.assign is not acting consistently between node's runtime and Chrome. From Select.js#820
|
instanceID is also a (undocumented) property. Set it to make sure it's the same on server and client. |
Oh just saw you found that - weird, I'm running isomorphic as well and don't have a problem with node and Chrome. |
Looks like i'm running into this now: facebook/react#6451 |
Hi! I get same error in my isomorphic app. Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server: Please, fix it, or add prop instanceID to Docs. |
I haven't looked into this deeply, but i'm seeing render warnings on client-side render in our isomorphic app. Looks like some state is being incremented on persistence? This is using 1.0rc2.
The text was updated successfully, but these errors were encountered: