Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible test failure in upcoming Julia version 1.5 #41

Closed
rfourquet opened this issue Apr 24, 2020 · 3 comments
Closed

possible test failure in upcoming Julia version 1.5 #41

rfourquet opened this issue Apr 24, 2020 · 3 comments

Comments

@rfourquet
Copy link

A PkgEval run for a PR which changes the generated numbers for randn! indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.
cf. https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/MIRT/1.5.0-DEV-71a4a114c2.log

@JeffFessler
Copy link
Owner

Thanks for alerting me. It turns out that I had a tolerance that was too small there, so I have changed it to use isapprox and I suspect it will be fine now. It passes Julia 1.4 tests. I tried to test 1.5 on TravisCI but I guess they are not yet supporting 1.5. So I downloaded the latest nightly build of 1.5 and tested it locally and it passed.
It's wonderful that the Julia community has these tools that help us be proactive! Thanks!

@rfourquet
Copy link
Author

You're welcome! Actually the PR was merged just before opening the issue, so I guess the "latest nightly build" doesn't contain yet the change. But yes, using isapprox will probably be enough (but the change also broke some tests which had isapprox).

@JeffFessler
Copy link
Owner

I tested with a newer nightly and it passed, after fixing some other new issues. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants