Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't derive From by default for variants without fields #106

Closed
JelteF opened this issue Nov 12, 2019 · 1 comment
Closed

Don't derive From by default for variants without fields #106

JelteF opened this issue Nov 12, 2019 · 1 comment
Milestone

Comments

@JelteF
Copy link
Owner

JelteF commented Nov 12, 2019

There's not really a reason to derive from for () for variants without fields. It's somewhat unexpected and results in the problems described here in #105. Let's remove this in the next breaking release, probably 1.0.

@Robbepop
Copy link

Robbepop commented Jan 9, 2020

Could you also please make a warning if a crate has some spurious #[from(ignores)] that it would no longer need with version 1.0. I currently am having many of those #[from(ignore]) annotations in my crates and it would be a blessing to have some indicators by the macro itself if they are no longer useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants