This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
v1.0.3 #7
JesseCoretta
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This discussion pertains to the pending release of v1.0.3 via PR #9
v1.0.3 brings significant performance improvements. No new features are added.
The log subsystem behavior is now less engaged. Users may still supply their own *log.Logger, however no internal use of any log system occurs by default now. Overzealous internal use resulted in significant performance degradation.
A (pprof) performance analysis was done to guide this pull request. Certain inefficiencies were identified and corrected (largely those involving aforementioned log use).
Code coverage remains 100%. Test times dropped from 0.2s to 0.005s on average.
I also investigated the possibility of reducing calls to
append
, however due to the nature of how the underlying*stack
type is used, this seemed to be more trouble than it would be worth (given the radically improved performance changes mentioned above).Its OK To Append Sometimes.™️
Beta Was this translation helpful? Give feedback.
All reactions