Attempt to get line out of bounds

[serjsysoev]

There are a lot of cases when TerminalTextBuffer#getLine logs "Attempt to get line out of bounds: a >= b"

[omegaui]

May be I can help!

As far as I know You can provide the maximum line count using the DefaultSettingsProvider
Like this,

It may prevent the log message.

[serjsysoev]

@omegaui Hi!
Unfortunately, it won’t help with this log message. The problem is there are a lot of cases when getLine is called with out-of-bounds parameters. I fixed one of these in this commit.

clearLines(beginY, endY); is being called with endY = myTerminalHeight which is out-of-bounds for this function. It in turn calls LinesBuffer#clearLines which calls getLine(i).clear(filler) with out-of-bounds index.

We want to fix all cases where this happens. I think we need to fix the obvious out-of-bounds calls and at least print stack trace so we can understand what causes this issue.

If you have a way to consistently reproduce this behavior or an explanation how this could happen, please file a separate issue.
Thank you!