From 9958ffa47d1dec29921a6423a653eb6d28ad6977 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Braun?= Date: Mon, 25 Nov 2024 19:14:09 +0100 Subject: [PATCH 1/2] Increase minimum size of Day text in DayHeader --- .../kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt b/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt index 9cfb89db..304b255f 100644 --- a/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt +++ b/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt @@ -66,7 +66,7 @@ fun DayHeader( day, style = DayDateStyle, color = KotlinConfTheme.colors.primaryTextInverted, - modifier = Modifier.width(70.dp), + modifier = Modifier.widthIn(min = 72.dp), ) StyledText( "", From 7ad46f433cad2c7a30878f8035aafcc4346a09ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Braun?= Date: Tue, 26 Nov 2024 00:40:12 +0100 Subject: [PATCH 2/2] Fix PageTitle accessibility --- .../org/jetbrains/kotlinconf/ui/components/PageTitle.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/PageTitle.kt b/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/PageTitle.kt index f4947cf5..8a57ffe2 100644 --- a/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/PageTitle.kt +++ b/ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/PageTitle.kt @@ -10,7 +10,7 @@ import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.wrapContentSize -import androidx.compose.foundation.selection.selectable +import androidx.compose.foundation.selection.toggleable import androidx.compose.material3.Icon import androidx.compose.runtime.Composable import androidx.compose.runtime.getValue @@ -77,9 +77,9 @@ fun PageTitle( modifier = Modifier .size(24.dp) .wrapContentSize(unbounded = true) - .selectable( - selected = bookmarked, - onClick = { onBookmark(!bookmarked) }, + .toggleable( + value = bookmarked, + onValueChange = { onBookmark(it) }, role = Role.Checkbox, indication = null, interactionSource = null,