Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit failure makes commit message disappear #248

Closed
jelle-it opened this issue Oct 31, 2024 · 1 comment
Closed

Pre-commit failure makes commit message disappear #248

jelle-it opened this issue Oct 31, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jelle-it
Copy link

Describe the bug
I have a pre-commit hook running, so when I press the commit button it runs. When it fails, I get a nice message that my commit failed because of the pre-commit hook. But what is weird is that the commit message goes away. The message however comes back when i switch to another repository and go back.

To Reproduce
Steps to reproduce the behavior:

  1. Enable a pre-commit hook
  2. Put code in staging that will fail the pre-commit hook
  3. Add commit message
  4. Press commit
  5. Close error popup
  6. The message is gone from the commit message box

If you want it back you can follow these steps:

  1. Navigate to another tab (repository or New tab)
  2. Navigate back
  3. The message is restored

Expected behavior
The message should not go away at all.

Screenshots

381957740-1f4e765e-bed7-4cf3-a165-7866279b12fc.mov

Desktop (please complete the following information):

  • OS: MAC
  • Version 1.4.0
@jelle-it jelle-it added the bug Something isn't working label Oct 31, 2024
@JetpackDuba
Copy link
Owner

Hello,

Good catch, I'll try to have it fixed for the 1.4.1 release (will be released this weekend).

Thank you!

@JetpackDuba JetpackDuba added this to the 1.4.1 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants