-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new release artifact x86_64-unknown-linux-musl #834
Conversation
Sorry for the delay, and thanks for the contribution! The only thing I am worried about here is the format of the name. Unfortunately we didn't leave much flexibility in the way the artifact name is structured, and I know many tools hardcode the structure to determine what asset to download. We do this ourselves in multiple places:
And we will need to make sure this new package name doesn't affect those at the minimum, let alone the third party packagers (but it is impossible to control all of them). But..., the concern here is only that these tools don't accidently pick up the new artifact, and just use the current ones still. So, we just need to structure it in that way. I think maybe |
Fully agree. I was not aware of this jungle of regexes 😅 What do you think instead to move the alias |
I think we should leave the alias for now. The alias artifact is actually deprecated and I intend to remove it at the next major release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 97.02% 97.03%
=======================================
Files 16 16
Lines 5989 5995 +6
=======================================
+ Hits 5811 5817 +6
Misses 178 178 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I don't anticipate any problems, but let's see at the next release. If something comes up, I can just remove the zip from the release artifacts temporarily.
Hi, thanks for
stylua
formatter! I use it a lot within neovim.The aim of this PR is to support distro like Alpine Linux (on amd64 arch),
building and attaching a new artifact for the target
x86_64-unknown-linux-musl
when releasing with
release.yml
workflowFrom local tests, the build process for this new target finished without errors ... only one warning
related to the
[lib]
part ofCargo.toml
Let me know if I need to do something ... maybe trigger some CI to test
stylua
works also for this new target