Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring]: Avatar/UserAvatar/AvatarWithAddress #3711

Open
Nortsova opened this issue Nov 14, 2024 · 0 comments
Open

[Refactoring]: Avatar/UserAvatar/AvatarWithAddress #3711

Nortsova opened this issue Nov 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Nortsova
Copy link
Contributor

Steps to reproduce

While working on #3624, I realized that there's no reusable component that accepts an address and renders an avatar alongside it. However, similar functionality exists in different places. This task aims to refactor and unify the approach.

image

Expected behaviour

I am pretty sure we can create a nice, reusable component that includes an avatar, address, a warning indicator (or status prop), and a verification tick (we can go with general {icon} instead of a specific verification icon). The address could be validated and optionally masked or shortened.

Masked address: https://github.com/JoinColony/colonyCDapp/pull/3624/files#diff-88fbbc8dcc49fa2725c3362d51653a0d5a0d26e6906aaf87cb1d13991e724343

Actual behaviour

Duplications and similar but different logic:

image image image
@Nortsova Nortsova added the bug Something isn't working label Nov 14, 2024
@rdig rdig added enhancement New feature or request and removed bug Something isn't working labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants