From 225b330a3b4e01ba3dc3a698ccaf6a717f385dad Mon Sep 17 00:00:00 2001 From: strzelec Date: Fri, 24 Jan 2025 16:46:01 +0100 Subject: [PATCH 1/4] fix: staged payment table content position --- .../partials/StagedPaymentRecipientsField/hooks.tsx | 2 +- .../StagedPaymentTable/StagedPaymentTable.tsx | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/components/v5/common/ActionSidebar/partials/forms/StagedPaymentForm/partials/StagedPaymentRecipientsField/hooks.tsx b/src/components/v5/common/ActionSidebar/partials/forms/StagedPaymentForm/partials/StagedPaymentRecipientsField/hooks.tsx index ac4546f41a..f6bc11e0ee 100644 --- a/src/components/v5/common/ActionSidebar/partials/forms/StagedPaymentForm/partials/StagedPaymentRecipientsField/hooks.tsx +++ b/src/components/v5/common/ActionSidebar/partials/forms/StagedPaymentForm/partials/StagedPaymentRecipientsField/hooks.tsx @@ -86,7 +86,7 @@ export const useStagedPaymentRecipientsTableColumns = ( }), columnHelper.display({ id: 'amount', - staticSize: '216px', + staticSize: '210px', header: () => formatText({ id: 'table.row.amount' }), cell: ({ row }) => ( formatText({ id: 'table.row.amount' }), cell: ({ row }) => ( @@ -134,7 +134,7 @@ const useStagedPaymentTableColumns = ({ ? [ columnHelper.display({ id: 'release', - staticSize: '96px', + staticSize: '60px', enableSorting: false, cell: ({ row }) => { const { original } = row; @@ -179,7 +179,14 @@ const useStagedPaymentTableColumns = ({ : undefined, }), ] - : []), + : [ + columnHelper.display({ + id: 'release', + staticSize: '60px', + enableSorting: false, + cell: () => null, + }), + ]), ]; // eslint-disable-next-line react-hooks/exhaustive-deps }, [ From 0d4551e32727d475fae3f4d9f4fc3564fb29e03b Mon Sep 17 00:00:00 2001 From: strzelec Date: Fri, 31 Jan 2025 13:50:37 +0100 Subject: [PATCH 2/4] fix: improve tables appearance for mobile --- .../PaymentBuilderPayoutsTotal.tsx | 2 +- .../StagedPaymentTable/StagedPaymentTable.tsx | 111 ++++++++++++------ 2 files changed, 78 insertions(+), 35 deletions(-) diff --git a/src/components/v5/common/ActionSidebar/partials/forms/PaymentBuilderForm/partials/PaymentBuilderPayoutsTotal/PaymentBuilderPayoutsTotal.tsx b/src/components/v5/common/ActionSidebar/partials/forms/PaymentBuilderForm/partials/PaymentBuilderPayoutsTotal/PaymentBuilderPayoutsTotal.tsx index 1e869a2960..fc86a78ccc 100644 --- a/src/components/v5/common/ActionSidebar/partials/forms/PaymentBuilderForm/partials/PaymentBuilderPayoutsTotal/PaymentBuilderPayoutsTotal.tsx +++ b/src/components/v5/common/ActionSidebar/partials/forms/PaymentBuilderForm/partials/PaymentBuilderPayoutsTotal/PaymentBuilderPayoutsTotal.tsx @@ -89,7 +89,7 @@ const PaymentBuilderTokensTotal: FC = ({ )} > -
+
1; - const isMobile = useMobile(); + const isTablet = useTablet(); const { stagedExpenditureAddress } = useEnabledExtensions(); const hasMoreThanOneMilestone = dataRef.current.filter((item) => !item.isClaimed).length > 1; @@ -68,6 +68,17 @@ const useStagedPaymentTableColumns = ({ const columnHelper = createColumnHelper(); + const releaseTableSpacer = isTablet + ? [] + : [ + columnHelper.display({ + id: 'release', + staticSize: '60px', + enableSorting: false, + cell: () => null, + }), + ]; + return [ columnHelper.accessor('milestone', { header: () => formatText({ id: 'table.row.milestone' }), @@ -112,23 +123,25 @@ const useStagedPaymentTableColumns = ({ isLoading={isLoading} /> ), - footer: hasMoreThanOneToken - ? () => ( - <> - - {isMobile && - isPaymentStep && - hasMoreThanOneMilestone && - isCorrectExtensionInstalled && ( - - )} - - ) - : undefined, + ...((!isTablet || !isPaymentStep) && { + footer: hasMoreThanOneToken + ? () => { + return ( +
+ +
+ ); + } + : undefined, + }), }), ...(isPaymentStep ? [ @@ -144,7 +157,11 @@ const useStagedPaymentTableColumns = ({ const isClaimed = currentMilestone?.isClaimed; return isClaimed ? ( -
+
- : undefined, + hasMoreThanOneMilestone && isCorrectExtensionInstalled + ? () => ( +
+ {isTablet && ( +
+ +
+ )} + + +
+ ) + : () => + isTablet ? ( +
+ {isTablet && ( +
+ +
+ )} +
+ ) : undefined, }), ] - : [ - columnHelper.display({ - id: 'release', - staticSize: '60px', - enableSorting: false, - cell: () => null, - }), - ]), + : releaseTableSpacer), ]; // eslint-disable-next-line react-hooks/exhaustive-deps }, [ hasMoreThanOneToken, isPaymentStep, - isMobile, hasMoreThanOneMilestone, isCorrectExtensionInstalled, isLoading, @@ -201,6 +243,7 @@ const useStagedPaymentTableColumns = ({ // Even though this is not directly used, it is needed to refresh the ReleaseButton isPendingStagesRelease, allMilestonesSlotIdsAwaitingRelease.length, + isTablet, ]); return columns; From 0f9a2289e666a6ab62db7da7443d46bde90d9e6c Mon Sep 17 00:00:00 2001 From: strzelec Date: Mon, 3 Feb 2025 19:14:35 +0100 Subject: [PATCH 3/4] fix: align payment link and hide footer when only one milestone --- .../StagedPaymentTable/StagedPaymentTable.tsx | 52 ++++++++++--------- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx b/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx index f68e387b3c..dda16fdbd6 100644 --- a/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx +++ b/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx @@ -173,7 +173,7 @@ const useStagedPaymentTableColumns = ({ ) : ( <> {isCorrectExtensionInstalled ? ( -
+
); }, - footer: - hasMoreThanOneMilestone && isCorrectExtensionInstalled - ? () => ( -
- {isTablet && ( -
- -
- )} - - -
- ) - : () => - isTablet ? ( + ...(hasMoreThanOneToken && { + footer: + hasMoreThanOneMilestone && isCorrectExtensionInstalled + ? () => (
)} + +
- ) : undefined, + ) + : () => + isTablet ? ( +
+ {isTablet && ( +
+ +
+ )} +
+ ) : undefined, + }), }), ] : releaseTableSpacer), From 761336120493e708cd6a7c9c1f200974d2015933 Mon Sep 17 00:00:00 2001 From: strzelec Date: Tue, 11 Feb 2025 13:48:17 +0100 Subject: [PATCH 4/4] fix: rebase fixes --- .../partials/StagedPaymentTable/StagedPaymentTable.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx b/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx index dda16fdbd6..9d1fdb9047 100644 --- a/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx +++ b/src/components/v5/common/CompletedAction/partials/PaymentBuilder/partials/StagedPaymentTable/StagedPaymentTable.tsx @@ -173,7 +173,7 @@ const useStagedPaymentTableColumns = ({ ) : ( <> {isCorrectExtensionInstalled ? ( -
+