Report disk model under FreeBSD

[danfe]

I've added your program to FreeBSD ports and had to patch it a bit so it reports disk model correctly; would be nice if you could merge the patch, it's rather small and simple. Of course, I've forgotten to close(fd) before returning from the function. :-(

[JonMagon]

Hi! Thank you. Why is there sys/fcntl.h included? Maybe it is better to use QFile, which is already included in diskdriveinfo.cpp?

[danfe]

Why is there sys/fcntl.h included?

To get O_RDONLY definition. Should've probably be spelled as simply fcntl.h though.

Maybe it is better to use QFile, which is already included in diskdriveinfo.cpp?

Isn't QFile mainly for reading and writing files, while here we open device node to call ioctl() on it?

[JonMagon]

Isn't QFile mainly for reading and writing files, while here we open device node to call ioctl() on it?

Oh right, I read the code wrong. I'll create a commit.

[danfe]

Thanks! I forgot to mention that close(2) needs #include <unistd.h> but I guess that can wait for another day.

[JonMagon]

I couldn't check, is it okay now?

[danfe]

Yup, it's fine, thanks!