#63: Adding `ar` shorthand for aspect and support for numeric values for aspect #74

tony-sull · 2021-04-26T10:40:35Z

Integrating feedback from polarathene's comment, better matching Cloudinary's support for aspect ratio

This adds ar as a shorthand for aspect in the resize transform, e.g. ar=16:9 is the same as aspect=16:9

This also adds support for numeric aspect values representing the width divided by height, e.g. aspect=1.5 is the same as aspect=3:2

…pect=1.5"

…lues

…tfix/aspect-directive

JonasKruckenberg

You should also add the ar property to the ResizeOptions interface, but the rest looks good 👍

packages/core/src/transforms/resize.ts

…ng `aspect` or `ar`

packages/core/package.json

Tony Sullivan added 3 commits April 26, 2021 12:24

adding shorthand "ar" to aspect keyword, allow number values like "as…

1fa3df2

…pect=1.5"

updating directive docs for ar shorthand and support for numeric va…

651786a

…lues

Merge branch 'main' of github.com:JonasKruckenberg/imagetools into ho…

de9b7f6

…tfix/aspect-directive

JonasKruckenberg requested changes Apr 26, 2021

View reviewed changes

packages/core/src/transforms/resize.ts Outdated Show resolved Hide resolved

adding ar to ResizeOptions interface, simplifying the logic for usi…

fb32b41

…ng `aspect` or `ar`

JonasKruckenberg approved these changes Apr 26, 2021

View reviewed changes

JonasKruckenberg requested changes Apr 26, 2021

View reviewed changes

packages/core/package.json Outdated Show resolved Hide resolved

removing temporary test script

cd06179

JonasKruckenberg approved these changes Apr 26, 2021

View reviewed changes

JonasKruckenberg merged commit e96b7e3 into JonasKruckenberg:main Apr 26, 2021

Provide feedback