Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directions for CHANGE_DESKTOP Up/Down/Left/Right #338

Closed
ska2342 opened this issue Sep 21, 2020 · 7 comments
Closed

Directions for CHANGE_DESKTOP Up/Down/Left/Right #338

ska2342 opened this issue Sep 21, 2020 · 7 comments
Assignees
Milestone

Comments

@ska2342
Copy link

ska2342 commented Sep 21, 2020

Over the weekend and I looked into providing a PR that would allow to give direction "up", "down", "left", "right" similar to how "next" and "previous" work currently in the CHANGE_DESKTOP action.

But I stumbled over all the flexibility that the EWMH _NET_DESKTOP_LAYOUT allows.

Would you be happy to receive a PR that only deals with one orientation and one starting corner and be tested on KDE?

@JoseExposito
Copy link
Owner

Hi @ska2342 ,

First of all, thank you very much for your work!

Indeed _NET_DESKTOP_LAYOUT is powerful. I already had a look into it, but I discarded the idea because, in my opinion, having just previous/next provides a better user experience, let me explain it:

Having gestures to navigate to the desktop placed up/down/left/right will force you reserve 4 different gestures just for desktop navigation, lets say 4 fingers swipes. That doesn't leave you room to use other actions like showing the desktop (this is specially useful in KDE, to easily check your plasmoids) or presenting windows. However, with just previous/next you have more room for more gestures and you can easily navigate through your desktops.

However, I'll leave this issue open and if it receives enough 👍 reactions I'll implement this feature for 2.0.1.

I guess being able to use previous/next in addition to up/down/left/right will fit both user cases 😄

@ska2342
Copy link
Author

ska2342 commented Sep 22, 2020

I humbly disagree here. Living on a 3x3 grid of desktops since 1995, "next" and "previous" don't make sense to me at all. I never think of my desktops as a linked list or a row or anything else 1d. I wouldn't mind having to use 4 gestures for this. (Personally, I'd likely go with 3 finger swipes in the different directions.)

Unfortunately, I have no idea in which way other window managers chose to set the desktop layout. KDE Plasma just sets the number of rows and let's you figure out the columns yourself from the total number of desktops. They have a horizontal orientation and the starting corner is top left.

Also, boy is my C++ rusty! ;-)

@JoseExposito
Copy link
Owner

Fair enough, I'll try my best and add support for it in a future release 😄

@ska2342
Copy link
Author

ska2342 commented Sep 22, 2020

I can try this, too. But please be aware that it's been ca 15 years since I last coded in C++.

@JoseExposito
Copy link
Owner

JoseExposito commented Oct 12, 2020

Hi @ska2342

I just added support for up/down/left/right in CHANGE_DESKTOP 😄

In case you want to try it, you can compile the latest source code, or wait for the 2.0.2 release.

Jose

@JoseExposito JoseExposito added this to the 2.0.2 milestone Oct 12, 2020
@JoseExposito JoseExposito self-assigned this Oct 12, 2020
@ska2342
Copy link
Author

ska2342 commented Oct 12, 2020

Cool! I set the 3 finger swipe to desktop switching up/down/left/right and it seems to work fine. Personally, I'm super happy that it doesn't scroll when hitting an edge. I can imagine that there will be people who disagree. ;-)

FWIW: KDE Plasma on Kubuntu 20.04 with 3x3 desktops.

@amerkay
Copy link

amerkay commented Dec 11, 2020

Hi,
I love this. Great work!

I'm trying to setup the the up/down/left/right CHANGE_DESKTOP on KDE and I can't seem to get it working. I see the animation arrows, but the desktop does not switch.

Oops, AUR has v2.0.0 - not the latest. Please ignore. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants