fix(943): if last character of suffix same as first letter inputted d… #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieGreenman
commented
Sep 17, 2022
|
anyone that has time to take a look at this pull request? |
|
@CharlieGreenman Thank you. Will look today. |
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o not remove
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a suffix such as
.shis added to the mask, and the first character a user inputs(e.g.h) is the last letter of the mask(e.g..sh) it will not allow the character(h) to be inputted.Issue Number: 943
What is the new behavior?
If it is the first character inputted, the assumption is always that it should be added to side step includes logic. All existing unit tests currently pass.
Does this PR introduce a breaking change?
Other information
Fixes the issue here: #943