Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define ReadOnlyVector and ReadOnlyMatrix #4

Closed
wmanning-cra opened this issue Jan 6, 2022 · 2 comments · Fixed by #5
Closed

Define ReadOnlyVector and ReadOnlyMatrix #4

wmanning-cra opened this issue Jan 6, 2022 · 2 comments · Fixed by #5

Comments

@wmanning-cra
Copy link
Contributor

Self-explanatory
@bkamins
Copy link
Collaborator

bkamins commented Jan 6, 2022

If you would find it useful I am OK to add it. Please go ahead and make a PR. The only thing to discuss if you want eg. ReadOnlyVector to enforce Vector or AbstractVector? I think the latter is better.

@wmanning-cra
Copy link
Contributor Author

Just made a PR for them. They are merely aliases for ReadOnlyArray, so they don't refer to Vector or AbstractVector at all.

#5

@wmanning-cra wmanning-cra linked a pull request Jan 18, 2022 that will close this issue
Add convenience features #5
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add convenience features wmanning-cra/ReadOnlyArrays.jl
2 participants
@bkamins @wmanning-cra