Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage misses on macros that work on functions #50

Closed
sbromberger opened this issue Apr 14, 2020 · 5 comments
Closed

Coverage misses on macros that work on functions #50

sbromberger opened this issue Apr 14, 2020 · 5 comments
Labels

Comments

@sbromberger
Copy link
Contributor

Hi all,

@traitfn functions (defined using SimpleTraits) are no longer counted as covered. (They used to be.)

Here's an example - it seems that even though the function body is being covered, the declaration isn't.

Any way we could restore the previous behavior? Thanks.

@aminya
Copy link

aminya commented Jun 14, 2020

I have the same problem in JuliaCI/Coverage.jl#275

@aminya
Copy link

aminya commented Jun 14, 2020

@sbromberger This is a Julia issue. You can track it here. JuliaLang/julia#36283
This should be closed.

@fingolfin fingolfin changed the title SimpleTraits regression? Coverage misses on macros that work on functions Nov 6, 2020
@fingolfin fingolfin reopened this Nov 6, 2020
@fingolfin
Copy link
Member

Actually, let's keep this open, in case more people notice this and come looking here to report it.

@fingolfin
Copy link
Member

@sbromberger do you know when it used to work / with which Julia version?

@vtjnash vtjnash transferred this issue from JuliaCI/Coverage.jl Mar 26, 2021
@vtjnash
Copy link
Member

vtjnash commented Jun 22, 2021

@vtjnash vtjnash closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants