Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #494: interactive use of runic plugin #495

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

simeonschaub
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.11%. Comparing base (1b5bd08) to head (9cdbb26).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/formatter.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   94.23%   94.11%   -0.12%     
==========================================
  Files          24       24              
  Lines         746      748       +2     
==========================================
+ Hits          703      704       +1     
- Misses         43       44       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have checked this manually?

@simeonschaub
Copy link
Collaborator Author

Yes, I confirmed it locally

@simeonschaub simeonschaub merged commit f9a88a4 into master Jan 22, 2025
14 of 16 checks passed
@simeonschaub simeonschaub deleted the sds/fix_runic_interactive branch January 22, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants