Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement support for current_scope #605

Merged
merged 2 commits into from
Jan 9, 2024
Merged

implement support for current_scope #605

merged 2 commits into from
Jan 9, 2024

Conversation

aviatesk
Copy link
Member

No description provided.

@aviatesk aviatesk requested a review from Keno December 22, 2023 14:07
@Keno
Copy link
Member

Keno commented Dec 22, 2023

Seems reasonable, but it feels like there needs to be something that actually reflects the shadow copy of the current scope here into the runtime upon calling a native function. Not sure if that's here or in Debugger.jl

@aviatesk aviatesk mentioned this pull request Jan 8, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (580b95c) 85.64% compared to head (2d026eb) 85.38%.

❗ Current head 2d026eb differs from pull request most recent head 9ce455e. Consider uploading reports for the commit 9ce455e to get more accurate results

Files Patch % Lines
src/builtins.jl 30.00% 7 Missing ⚠️
src/interpret.jl 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   85.64%   85.38%   -0.26%     
==========================================
  Files          12       12              
  Lines        2515     2525      +10     
==========================================
+ Hits         2154     2156       +2     
- Misses        361      369       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviatesk
Copy link
Member Author

aviatesk commented Jan 9, 2024

This PR impacts the nightly CI only, although the nightly CI are all failing due to unrelated issues to this PR, primarily due to issues #610 and possibly #591.
Despite the failures, the tests added in this PR have been successfully executed on my local nightly build. Considering this PR also resolves the Check builtins.jl CI issue, I'd like to move forward with it.

@aviatesk aviatesk merged commit 713c768 into master Jan 9, 2024
6 of 12 checks passed
@aviatesk aviatesk deleted the avi/scopedvalue branch January 9, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants