Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible test failure in upcoming Julia version 1.5 #176

Closed
rfourquet opened this issue Apr 24, 2020 · 1 comment
Closed

possible test failure in upcoming Julia version 1.5 #176

rfourquet opened this issue Apr 24, 2020 · 1 comment
Labels
testing Related to tests

Comments

@rfourquet
Copy link

A PkgEval run for a PR which changes the generated numbers for randn! indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.
cf.
https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/ChainRules/1.5.0-DEV-71a4a114c2.log
@nickrobinson251 nickrobinson251 added the testing Related to tests label Apr 29, 2020
@gxyd
Copy link
Contributor

gxyd commented Nov 17, 2020

I tested with julia 1.5 on ubuntu 16.04 and tests seem to be passing with latest master branch.

https://gist.github.com/gxyd/b6d93956da4dbdb9734f664c487ab5bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Related to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oxinabox @gxyd @rfourquet @nickrobinson251