Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default font for REPL "output" produces poor alignment w/ box-drawing unicode #1561

Closed
thchr opened this issue Apr 6, 2021 · 9 comments
Closed

Comments

@thchr
Copy link

thchr commented Apr 6, 2021

E.g., using the PrettyTables package leads to unaligned columns, as below (see also examples in PrettyTables' documentation):
image
There's some issues with the font (is it Julia Mono?) not being truly monospace or with it falling back to another font perhaps.

In an ideal world, it would be possible to easily change the various fonts used in documentation (#973) - but having a genuinely monospace font for REPL display would be lovely in the meanwhile.
(If this is just a fallback issue, then #973 may be sufficient for this issue)

@fredrikekre
Copy link
Member

Duplicate of #618.

@cormullion
Copy link
Contributor

(is it Julia Mono?)

I hope not... :) If it were, it would look like this (macOS/Safari):

Screenshot 2021-04-15 at 10 57 56

@fredrikekre
Copy link
Member

I would be in favor of using JuliaMono as the default font for code. It looks like JuliaMono is now available from a proper CDN so I assume infrastructure wouldn't be a problem?

It would at least be nice to include some docs on how to change it (e.g. JuliaDiff/ChainRulesCore.jl#293)

@cormullion
Copy link
Contributor

I've seen the (Google?) CDN for Lato/Roboto fail once (a Sunday morning a few years ago), so no system is going to be perfect... Given how awesome all the Julia package infrastructure people are, perhaps serving a few 800 Kb font files wouldn't be too much of an extra load? 😄

@fredrikekre
Copy link
Member

I mean, it seems to be available from https://cdn.jsdelivr.net/gh/cormullion/juliamono/webfonts/JuliaMono-Regular.woff2 so that shouldn't hit any Julia-related infrastructure at all, right?

@cormullion
Copy link
Contributor

Yes, that's the current CDN. It's just that that service appears to be intended more for (or mainly for) JavaScript and Node (NPM) packages. Should they ever decide to not support certain types of file, perhaps that would then be a problem. But that's true of most online services anyway, so ¯\_(ツ)_/¯...

@fredrikekre
Copy link
Member

I see. Would it be possible to use GH releases for individual files? I imagine GH has some type of CDN-like cache system too.

@fredrikekre
Copy link
Member

Actually, we can probably put it on something like https://julialang.org/assets/.... That website uses Fastly CDN I believe, so that should be fine.

@cormullion
Copy link
Contributor

Interesting idea - I'll open an issue and see what happens...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants