From 1a37f38acc0194047847fbf4ba7c5db8ca05a47e Mon Sep 17 00:00:00 2001 From: Fredrik Ekre Date: Wed, 28 Aug 2019 10:59:37 +0200 Subject: [PATCH] Use read + write instead of copying in order to fix file permission error when Documenter is Pkg.added. --- CHANGELOG.md | 5 +++++ test/doctests/fix/tests.jl | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f6e2df601..ed45d07217 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Documenter.jl changelog +## Version `v0.23.3` + +* ![Bugfix][badge-bugfix] Fix file permission error when `Pkg.test`ing Documenter. ([#1115][github-1115]) + ## Version `v0.23.2` * ![Bugfix][badge-bugfix] Empty Markdown headings no longer cause Documenter to crash. ([#1081][github-1081], [#1082][github-1082]) @@ -402,6 +406,7 @@ [github-1077]: https://github.com/JuliaDocs/Documenter.jl/pull/1077 [github-1081]: https://github.com/JuliaDocs/Documenter.jl/issues/1081 [github-1082]: https://github.com/JuliaDocs/Documenter.jl/pull/1082 +[github-1115]: https://github.com/JuliaDocs/Documenter.jl/pull/1115 [documenterlatex]: https://github.com/JuliaDocs/DocumenterLaTeX.jl [documentermarkdown]: https://github.com/JuliaDocs/DocumenterMarkdown.jl diff --git a/test/doctests/fix/tests.jl b/test/doctests/fix/tests.jl index 87fc2180f5..6e02cbc934 100644 --- a/test/doctests/fix/tests.jl +++ b/test/doctests/fix/tests.jl @@ -9,8 +9,11 @@ function test_doctest_fix(dir) srcdir = mktempdir(dir) builddir = mktempdir(dir) @debug "Testing doctest = :fix" srcdir builddir - cp(joinpath(@__DIR__, "broken.md"), joinpath(srcdir, "index.md")) - cp(joinpath(@__DIR__, "broken.jl"), joinpath(srcdir, "src.jl")) + + # Pkg.add changes permission of files to read-only, + # so instead of copying them we read + write. + write(joinpath(srcdir, "index.md"), read(joinpath(@__DIR__, "broken.md"))) + write(joinpath(srcdir, "src.jl"), read(joinpath(@__DIR__, "broken.jl"))) # fix up include(joinpath(srcdir, "src.jl")); @eval import .Foo