Use the new jl_method_lookup_by_tt API on 1.11. #550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPUCompiler's
methodinstance
function is pretty slow and allocates:That's why on 1.10, we improved this by using a generated function to cache the dynamic case, automatically invalidating the result when the world age changes:
This however is not always valid, see #530. That's why @vchuravy exposed Julia's methodinstance cache in JuliaLang/julia#52572, so that starting on 1.11 we can now always perform a runtime call that's still reasonably fast:
Although slower than our previous cache, it fixes #530:
I would propose to keep using the old version on 1.10 though, as nobody except @topolarity had run into its issues so far.