Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mangling of booleans and zeros #614

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

simonbyrne
Copy link
Contributor

Fixes #609.

I also noticed that zeros were not being mangled correctly (the n prefix should only be added if the value is negative, not if equal to zero).

@maleadt
Copy link
Member

maleadt commented Aug 11, 2024

Thanks! We probably should move this to a separate package at some point, and include some better testing (checking against a c++filt JLL or so). For now, good to have a fix.

@maleadt maleadt merged commit 6927945 into JuliaGPU:master Aug 11, 2024
1 check passed
@simonbyrne
Copy link
Contributor Author

Another improvement might be to use module names as namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mangler does not generate C++ valid names with boolean-valued parameters
2 participants