Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Don't run on PRs from forks a job which requires accessing a secret #661

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Feb 3, 2025

Also, fix name of input to codecov steps.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (6e2554c) to head (36bdcc5).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage   72.84%   73.45%   +0.60%     
==========================================
  Files          24       24              
  Lines        3300     3326      +26     
==========================================
+ Hits         2404     2443      +39     
+ Misses        896      883      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt
Copy link
Member

maleadt commented Feb 4, 2025

The alternative is using a pull-request-target rule which does have access to the secret. But I guess this is fine for now.

@maleadt maleadt merged commit 47a4a8b into JuliaGPU:master Feb 4, 2025
17 checks passed
@giordano giordano deleted the mg/no-buildkite-test branch February 4, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants