Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparseVariationalApproximation breaks with PDMats.jl v0.11.8 #131

Closed
simsurace opened this issue May 6, 2022 · 4 comments
Closed

SparseVariationalApproximation breaks with PDMats.jl v0.11.8 #131

simsurace opened this issue May 6, 2022 · 4 comments

Comments

@simsurace
Copy link
Member

When running the example, the optimization does not work properly, i.e. the optimal covariance matrix of the sparse approximation remains diagonal.

@simsurace
Copy link
Member Author

So I guess ApproximateGPs.jl depends on some internals of PDMats.jl then.

@devmotion
Copy link
Member

devmotion commented May 6, 2022

Indeed, it seems SparseVariationalApproximation uses the unexported PDMats.chol_lower:

using PDMats: chol_lower, ScalMat

(BTW it also uses some other internals such as https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/blob/master/src/SparseVariationalApproximationModule.jl#L26)

@st--
Copy link
Member

st-- commented May 7, 2022

(BTW it also uses some other internals such as https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/blob/master/src/SparseVariationalApproximationModule.jl#L26)

these are actually defined in https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/blob/master/src/utils.jl

@devmotion
Copy link
Member

Fixed by #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants