Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move quadrature to GPLikelihoods #53

Closed
rossviljoen opened this issue Sep 14, 2021 · 1 comment · Fixed by #123
Closed

Move quadrature to GPLikelihoods #53

rossviljoen opened this issue Sep 14, 2021 · 1 comment · Fixed by #123

Comments

@rossviljoen
Copy link
Collaborator

The various expected_loglik methods should really live in GPLikelihoods.jl since they're not at all specific to ApproxGPs.
@st--
Copy link
Member

st-- commented Sep 16, 2021

I'm happy to make a PR there once #54 is in.
(I also had a few thoughts on how to change it slightly, maybe a good opportunity to discuss at the same time)

@st-- st-- mentioned this issue Sep 16, 2021
Closed
@st-- st-- mentioned this issue Mar 29, 2022
Merged
@st-- st-- closed this as completed in #123 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move expected loglik to GPLikelihoods JuliaGaussianProcesses/ApproximateGPs.jl
2 participants
@st-- @rossviljoen