Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to back most things by staticvectors instead of tuples #106

Open
asinghvi17 opened this issue Apr 12, 2024 · 2 comments
Open

Try to back most things by staticvectors instead of tuples #106

asinghvi17 opened this issue Apr 12, 2024 · 2 comments
Assignees

Comments

@asinghvi17
Copy link
Member

They have better dispatches on math functions and coordinate transformations.

@skygering
Copy link
Collaborator

@asinghvi17 Did we decide on GI.Points or StaticVectors? Is the first step to make an equivalent of the tuples function and then just replace the tuples calls? Seems like this will have the biggest effects on the functions that actually return new geometries, so basically the clipping and cutting and other transformations.

I am happy to take a stab at this this weekend with a little clarification.

@asinghvi17
Copy link
Member Author

asinghvi17 commented Apr 12, 2024

I believe it was GI.Point(SVector((x, y, z, m)))

Yep, basically you'd replace tuples by SVector

@skygering skygering self-assigned this Apr 13, 2024
This was referenced Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants