Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GeoInterface.jl compatible tables #90

Closed
rafaqz opened this issue Apr 1, 2024 · 3 comments · Fixed by #91
Closed

Handle GeoInterface.jl compatible tables #90

rafaqz opened this issue Apr 1, 2024 · 3 comments · Fixed by #91
Labels
enhancement New feature or request

Comments

@rafaqz
Copy link
Member

rafaqz commented Apr 1, 2024

Probably we should allow GeoInterface.jl compatible tables in apply ? (Tables.jl compatible with a :geometry column or something else specified by GeoInterface.geometrycolumns).

But probably it should also return a Table? to keep the "returns a similar object" pattern.

Could we default to using a DataFrame and put DataFrames.jl part in an extension?

This means applyreduce could work with just Tables.jl but apply would need DataFrames.jl

@asinghvi17
Copy link
Member

Sounds like a plan - one could also do the same for applyreduce.

Doesn't apply work correctly on FeatureCollections already?

@asinghvi17
Copy link
Member

Apply works on GeoJSON feature collections but returns an object which is not compatible with the Tables.jl interface. Shapefile tables are not supported yet, unfortunately.

@asinghvi17 asinghvi17 added the enhancement New feature or request label Apr 1, 2024
@asinghvi17
Copy link
Member

Suppose a table has geometries of type Point, Polygon and MultiPolygon. Now, if someone calls apply on it targeting polygon types, do we skip the point, or throw an error? Does the reconstructed table contain the point (I want to say no)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants