Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let all polygon ops start with a bounding box query #97

Open
asinghvi17 opened this issue Apr 5, 2024 · 4 comments
Open

Let all polygon ops start with a bounding box query #97

asinghvi17 opened this issue Apr 5, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers juliacon To be implemented for JuliaCon

Comments

@asinghvi17
Copy link
Member

If the bounding boxes of the two polygons don't intersect, we can immediately short-circuit the evaluation of any polygon set operation. Would give up to 1000x speedup in some cases, and of course more for really complex polygons.

@asinghvi17 asinghvi17 added enhancement New feature or request good first issue Good for newcomers juliacon To be implemented for JuliaCon labels Apr 6, 2024
@rafaqz
Copy link
Member

rafaqz commented Apr 6, 2024

Precalculating the extents may help if we're going to do this multiple time with the same obect

@skygering
Copy link
Collaborator

@rafaqz Would we then want to store the extent within the GI polygons? Would we always precalculate, or would this be a user choice? It would also be good to sort the polygons by extent when validating multipolygons. This would change the types of the returned polygons.

@rafaqz
Copy link
Member

rafaqz commented Apr 13, 2024

if you use tuples I think you can pass calc_extent=true to embed it for all nested geoms

@skygering
Copy link
Collaborator

See the conversation in #107 for more implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers juliacon To be implemented for JuliaCon
Projects
None yet
Development

No branches or pull requests

3 participants