Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ZSTD_compressStream2 with endOp argument #49

Merged
merged 3 commits into from
May 19, 2024

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented May 19, 2024

  • Change compress! to use ZSTD_compressStream2 rather than ZSTD_compressStream
  • Add tests for endOp

This provides us with more flexibility regarding the streaming API. In particular
providing an endOp of :end will include the decompressed in the frame header.

Currently, this does not connect the transcode machinery with this functionality.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.17%. Comparing base (4c799fe) to head (8b977fa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   30.98%   32.17%   +1.19%     
==========================================
  Files           5        5              
  Lines         510      519       +9     
==========================================
+ Hits          158      167       +9     
  Misses        352      352              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nhz2 nhz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mkitti mkitti merged commit ad7288a into JuliaIO:master May 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants