axes() is ambiguous now

[Cody-G]

See JuliaImages/ImageAxes.jl#25

Also uses of the name axes as a keyword argument are causing problems.

[Evizero]

Also uses of the name axes as a keyword argument are causing problems.

This seems strange. What kind of problems?

[Cody-G]

This seems strange. What kind of problems?

My bad, now that I look at it again I think the stack trace was just off by a line. Here, for example, the problem is within _mappedarray but the stack trace points to the calling function. This happened several places, but now I think all of the traces were just off (due to inlining?).

julia> Pkg.test("ImageView")
INFO: Computing test dependencies for ImageView...
INFO: No packages to install, update or remove
INFO: Testing ImageView
WARNING: both Compat and AxisArrays export "axes"; uses of it in module ImageView must be qualified
Test Summary: | Pass  Total
contrast GUI  |    1      1
ERROR: LoadError: UndefVarError: axes not defined
Stacktrace:
 [1] #imshow#17(::Tuple{Symbol,Symbol}, ::String, ::Function, ::Symbol, ::Array{Any,1}, ::Function, ::AxisArrays.AxisArray{ColorTypes.RGB24,4,Array{ColorTypes.RGB24,4},Tuple{AxisArrays.Axis{:x,UnitRange{Int64}},AxisArrays.Axis{:y,UnitRange{Int64}},AxisArrays.Axis{:z,StepRange{Int64,Int64}},AxisArrays.Axis{:time,UnitRange{Int64}}}}) at /home/cody/.julia/v0.6/ImageView/src/ImageView.jl:154
 [2] imshow(::AxisArrays.AxisArray{ColorTypes.RGB24,4,Array{ColorTypes.RGB24,4},Tuple{AxisArrays.Axis{:x,UnitRange{Int64}},AxisArrays.Axis{:y,UnitRange{Int64}},AxisArrays.Axis{:z,StepRange{Int64,Int64}},AxisArrays.Axis{:time,UnitRange{Int64}}}}) at /home/cody/.julia/v0.6/ImageView/src/ImageView.jl:154
 [3] include_from_node1(::String) at ./loading.jl:576
 [4] include(::String) at ./sysimg.jl:14
 [5] process_options(::Base.JLOptions) at ./client.jl:305
 [6] _start() at ./client.jl:371
while loading /home/cody/.julia/v0.6/ImageView/test/runtests.jl, in expression starting on line 8

So maybe it wasn't necessary for me to change the keyword argument name, I can revert that part if you prefer.

[Evizero]

I can revert that part if you prefer.

That would be nice. I think we should be conservative here if we can

[Cody-G]

Done. The new PR is much more minimal, sorry about that!

[Evizero]

thanks for doing this! while seemingly little this Compat error seems to affect quite a few people