Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example doesn't work for all RDataset versions #384

Closed
PallHaraldsson opened this issue May 10, 2020 · 2 comments
Closed

Example doesn't work for all RDataset versions #384

PallHaraldsson opened this issue May 10, 2020 · 2 comments

Comments

@PallHaraldsson
Copy link
Contributor

PallHaraldsson commented May 10, 2020

E.g. not for whatever verion I had installed, nor for recent (lots of errors):

(@v1.5) pkg> add RDatasets#v0.6.5

But RDatasets#v0.6.5 (currently) latest works, so I considered a PR to README, adding:

using RDatasets  # e.g. verson 0.6.7 works

You would think since the latest works, it would stay that way, but seeing ggplot.png is 4 years old, it seems later versions broke and fixed, and could happen again. Most uses should know to use latest, but may not know, and blame your package, and you really do not want that package as a dependency with version bounds.

@randy3k
Copy link
Member

randy3k commented May 10, 2020

As far as I know, the current version of RCall depends on DataFrame.jl v0.21 but RDatasets.jl doesn't support it.

@PallHaraldsson
Copy link
Contributor Author

There's no big problem, i.e. it does work with latest RDatasets.jl. I'm just saying, for newbies, if you have it installed, like I did, and it's not up to date, as you do not have a dependency, your example will not work (until you figure out and update).

@palday palday closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants