Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality for decorated intervals #394

Closed
dpsanders opened this issue Jun 24, 2020 · 3 comments · Fixed by #590
Closed

Equality for decorated intervals #394

dpsanders opened this issue Jun 24, 2020 · 3 comments · Fixed by #590

Comments

@dpsanders
Copy link
Member

Currently we have

julia> DecoratedInterval(1..2, com) ==  DecoratedInterval(1..2, trv)
true

Is this specified in the standard?

cc @krish8484

@krish8484
Copy link
Collaborator

krish8484 commented Jun 26, 2020

According to section 11.5.3 of the standard, "For decorations, comparison operations for equality = and its negation shall be provided, as well as comparisons >,<,≥,≤ with respect to the propagation order (com > dac > def > trv > ill)"

But we also have this test in the ITF1788 suite,
@test ==(DecoratedInterval(Interval(1.0, 2.0), def), DecoratedInterval(Interval(1.0, 2.0), trv))
which is expecting a True answer(even though the decoration is different).

@dpsanders
Copy link
Member Author

I understand that statement from the standard as referring only to decorations, not to decorated intervals.

I think we should follow the behaviour of the octave interval package here.

@krish8484
Copy link
Collaborator

In the test suite we have,
DecoratedInterval(2, 1) == nai() == true
but
nai() == nai() == false
Aren't they contradicting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants