Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests in errors testset with libcurl 8.10 #261

Closed
giordano opened this issue Sep 18, 2024 · 1 comment · Fixed by #267
Closed

Failing tests in errors testset with libcurl 8.10 #261

giordano opened this issue Sep 18, 2024 · 1 comment · Fixed by #267

Comments

@giordano
Copy link
Contributor

Besides the issue described in #260, with a local build of libcurl 8.10 I have a failing test in Downloads.jl:

errors: Test Failed at /Users/mose/repo/Downloads.jl/test/runtests.jl:355
  Expression: err.response.proto === nothing
   Evaluated: "https" === nothing

Stacktrace:
 [1] macro expansion
   @ ~/repo/julia/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:679 [inlined]
 [2] macro expansion
   @ ~/repo/Downloads.jl/test/runtests.jl:355 [inlined]
 [3] macro expansion
   @ ~/repo/julia/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:1703 [inlined]
 [4] macro expansion
   @ ~/repo/Downloads.jl/test/runtests.jl:336 [inlined]
 [5] macro expansion
   @ ~/repo/julia/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:1703 [inlined]
 [6] top-level scope
   @ ~/repo/Downloads.jl/test/runtests.jl:4
errors: Test Failed at /Users/mose/repo/Downloads.jl/test/runtests.jl:361
  Expression: err.response.proto === nothing
   Evaluated: "https" === nothing

Stacktrace:
 [1] macro expansion
   @ ~/repo/julia/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:679 [inlined]
 [2] macro expansion
   @ ~/repo/Downloads.jl/test/runtests.jl:361 [inlined]
 [3] macro expansion
   @ ~/repo/julia/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:1703 [inlined]
 [4] macro expansion
   @ ~/repo/Downloads.jl/test/runtests.jl:336 [inlined]
 [5] macro expansion
   @ ~/repo/julia/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:1703 [inlined]
 [6] top-level scope
   @ ~/repo/Downloads.jl/test/runtests.jl:4

I don't know if we need to do something to adapt to libcurl 8.10 (which would suggest that was a breaking version, together with the trouble in #260), or we were doing something wrong already.

@giordano
Copy link
Contributor Author

giordano commented Jan 5, 2025

Failing tests are the err.response.proto === nothing checks at

err = @exception download("https://domain.invalid")
@test err isa RequestError
@test err.code != 0
@test startswith(err.message, "Could not resolve host")
@test err.response.proto === nothing
err = @exception request("https://domain.invalid", input = IOBuffer("Hi"))
@test err isa RequestError
@test err.code != 0
@test startswith(err.message, "Could not resolve host")
@test err.response.proto === nothing
Did they just change the protocol in the response and we need to change the expected result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant