Build issue on nightly - JULIA_HOME not defined

[tk3369]

Looks like JULIA_HOME has been renamed to JULIA_BINDIR.

$ cat /Users/tomkwong/.julia/packages/IJulia/tVAv/deps/build.log
Solving environment: ...working... done

# All requested packages already installed.

┌ Warning: `info()` is deprecated, use `@info` instead.
│   caller = top-level scope at build.jl:31
└ @ Core build.jl:31
INFO: Installing Jupyter via the Conda package.
┌ Warning: `convert(::Type{VersionNumber}, v::AbstractString)` is deprecated, use `VersionNumber(v)` instead.
│   caller = (::getfield(Main, Symbol("#prog_version#5")))(::String) at build.jl:17
└ @ Main build.jl:17
┌ Warning: `info()` is deprecated, use `@info` instead.
│   caller = top-level scope at build.jl:39
└ @ Core build.jl:39
INFO: Found Jupyter version 4.4.0: /Users/tomkwong/.julia/packages/Conda/BTNx/deps/usr/bin/jupyter
┌ Warning: `replace(s::AbstractString, pat, f)` is deprecated, use `replace(s, pat => f)` instead.
│   caller = installkernel(::String) at kspec.jl:36
└ @ Main kspec.jl:36
ERROR: LoadError: UndefVarError: JULIA_HOME not defined
Stacktrace:
 [1] uv_error at ./libuv.jl:68 [inlined]
 [2] unlink(::String) at ./file.jl:549
 [3] #rm#9(::Bool, ::Bool, ::Function, ::String) at ./file.jl:151
 [4] #rm at ./<missing>:0 [inlined]
 [5] #installkernel#6(::String, ::Function, ::String) at /Users/tomkwong/.julia/packages/IJulia/tVAv/deps/kspec.jl:117
 [6] installkernel(::String) at /Users/tomkwong/.julia/packages/IJulia/tVAv/deps/kspec.jl:36
 [7] top-level scope at /Users/tomkwong/.julia/packages/IJulia/tVAv/deps/build.jl:75
 [8] include at ./boot.jl:306 [inlined]
 [9] include_relative(::Module, ::String) at ./loading.jl:1072
 [10] include(::Module, ::String) at ./sysimg.jl:29
 [11] include(::String) at ./sysimg.jl:68
 [12] top-level scope
in expression starting at /Users/tomkwong/.julia/packages/IJulia/tVAv/deps/build.jl:104

My config:

julia> versioninfo()
Julia Version 0.7.0-DEV.4531
Commit 06eb54312e (2018-03-10 13:10 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin14.5.0)
  CPU: Intel(R) Core(TM) i5-4258U CPU @ 2.40GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, haswell)
Environment:

[stevengj]

Already addressed in #623.

[zahachtah]

Just a heads up: I use the new julia-beta2, update packages and then when build IJulia I get this old error again?:

(v0.7) pkg> build IJulia
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
  Building Conda ──→ `~/.julia/packages/Conda/S0nV/deps/build.log`
  Building MbedTLS → `~/.julia/packages/MbedTLS/u15M/deps/build.log`
  Building ZMQ ────→ `~/.julia/packages/ZMQ/Ih0B/deps/build.log`
  Building IJulia ─→ `~/.julia/packages/IJulia/oaZM/deps/build.log`
┌ Error: Error building `IJulia`: 
│ ┌ Warning: Deprecated syntax `try without catch or finally` at /Users/jonnorberg/.julia/packages/BinDeps/2wxq/src/dependencies.jl:122.
│ └ @ ~/.julia/packages/BinDeps/2wxq/src/dependencies.jl:122
│ Solving environment: ...working... done
│ 
│ # All requested packages already installed.
│ 
│ ┌ Warning: Deprecated syntax `try without catch or finally` at /Users/jonnorberg/.julia/packages/IJulia/oaZM/deps/build.jl:82.
│ └ @ ~/.julia/packages/IJulia/oaZM/deps/build.jl:82
│ ┌ Warning: `info()` is deprecated, use `@info` instead.
│ │   caller = top-level scope at build.jl:44
│ └ @ Core ~/.julia/packages/IJulia/oaZM/deps/build.jl:44
│ INFO: Installing Jupyter via the Conda package.
│ ┌ Warning: `convert(::Type{VersionNumber}, v::AbstractString)` is deprecated, use `VersionNumber(v)` instead.
│ │   caller = (::getfield(Main, Symbol("#prog_version#3")))(::String) at build.jl:22
│ └ @ Main ~/.julia/packages/IJulia/oaZM/deps/build.jl:22
│ ┌ Warning: `info()` is deprecated, use `@info` instead.
│ │   caller = top-level scope at build.jl:52
│ └ @ Core ~/.julia/packages/IJulia/oaZM/deps/build.jl:52
│ INFO: Found Jupyter version 4.4.0: /Users/jonnorberg/.julia/packages/Conda/S0nV/deps/usr/bin/jupyter
│ ┌ Warning: `replace(s::AbstractString, pat, f)` is deprecated, use `replace(s, pat => f)` instead.
│ │   caller = installkernel(::String) at kspec.jl:36
│ └ @ Main ~/.julia/packages/IJulia/oaZM/deps/kspec.jl:36
│ ERROR: LoadError: UndefVarError: JULIA_HOME not defined
│ Stacktrace:
│  [1] uv_error at ./libuv.jl:80 [inlined]
│  [2] unlink(::String) at ./file.jl:741
│  [3] #rm#9(::Bool, ::Bool, ::Function, ::String) at ./file.jl:253
│  [4] #rm at /Users/jonnorberg/.julia/packages/IJulia/oaZM/deps/kspec.jl:0 [inlined]
│  [5] #installkernel#4(::String, ::Function, ::String) at /Users/jonnorberg/.julia/packages/IJulia/oaZM/deps/kspec.jl:117
│  [6] installkernel(::String) at /Users/jonnorberg/.julia/packages/IJulia/oaZM/deps/kspec.jl:36
│  [7] top-level scope at /Users/jonnorberg/.julia/packages/IJulia/oaZM/deps/build.jl:88
│  [8] include at ./boot.jl:317 [inlined]
│  [9] include_relative(::Module, ::String) at ./loading.jl:1034
│  [10] include(::Module, ::String) at ./sysimg.jl:29
│  [11] include(::String) at ./client.jl:393
│  [12] top-level scope at none:0
│ in expression starting at /Users/jonnorberg/.julia/packages/IJulia/oaZM/deps/build.jl:9
└ @ Pkg.Operations /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/Pkg/src/Operations.jl:1007

[stevengj]

Fixed on master.