Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename add to add! for set operations that modify the input? #1962

Closed
diegozea opened this issue Jan 9, 2013 · 2 comments
Closed

rename add to add! for set operations that modify the input? #1962

diegozea opened this issue Jan 9, 2013 · 2 comments

Comments

@diegozea
Copy link
Contributor

diegozea commented Jan 9, 2013

I think that Set operations than perform modification on the actual set need to follow the ! convention.
@StefanKarpinski
Copy link
Member

The whole Set API needs some bikeshedding.

@StefanKarpinski StefanKarpinski mentioned this issue Jan 9, 2013
Closed
9 tasks
@JeffBezanson
Copy link
Member

Closed by b4d94d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKarpinski @JeffBezanson @diegozea