Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use reverse iteration protocol in foldr and mapfoldr #24823

Closed
stevengj opened this issue Nov 28, 2017 · 0 comments · Fixed by #31781
Closed

use reverse iteration protocol in foldr and mapfoldr #24823

stevengj opened this issue Nov 28, 2017 · 0 comments · Fixed by #31781
Labels
collections Data structures holding multiple items, e.g. sets

Comments

@stevengj
Copy link
Member

The foldr and mapfoldr operations require that one traverse an iterator in reverse order. However, the current implementation assumes that the iterator supports getindex and endof. Now that we have a reverse-iteration protocol, it would be good to use it here instead of getindex.
@stevengj stevengj added the collections Data structures holding multiple items, e.g. sets label Nov 28, 2017
@YingboMa YingboMa mentioned this issue Nov 29, 2017
Closed
This was referenced Apr 21, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
collections Data structures holding multiple items, e.g. sets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use Iterators.reverse for foldr etc. JuliaLang/julia
1 participant
@stevengj